LCppC backport: Replaced check for pipe() buffer size by ordinary CheckBufferOverrun#4183
Merged
Merged
Conversation
Contributor
Author
|
I tried to fix/update this rng file, but apparently I failed. Can someone please explain how this has to look like? |
Collaborator
|
Did you try this: |
… provide required Library configuration option Merged from LCppC.
Contributor
Author
|
Thanks, trying that out. |
Collaborator
|
👍 for replacing hard coded checking with configuration |
Contributor
|
man/reference-cfg-format.md documentation should be updated about this new attribute. |
Contributor
|
Also, with all these PRs, you should consider updating release-notes.txt with all these new features so it will be added to the notes for next release. |
Collaborator
yes. however for this PR there is no new checker so I guess the release-notes.txt can be kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to the discussion in PR4143, I am starting to provide a few fixes/improvements from LCppC to cppcheck, starting with those I backported and sent do danmar a year ago, but were not applied to cppcheck for unknown reasons.